linux-kernel - Re: [PATCH] staging: nvec: replace led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2597303.a4Sc8PqG2R@ax5200p>
Date:	Mon, 25 Jan 2016 22:00:30 +0100
From:	Marc Dietrich <marvin24@....de>
To:	"Gujulan Elango, Hari Prasath (H.)" <hgujulan@...teon.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: nvec: replace led_classdev_register

Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath:
> From: Hari Prasath Gujulan Elango <hgujulan@...teon.com>
> 
> Replace the led_classdev_register() with the platform managed version
> devm_led_classdev_register() & henceforth remove the redundant
> nvec_paz00_remove() function.
> 
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@...teon.com>

Thanks!

Acked-by: Marc Dietrich <marvin24@....de>

> ---
>  drivers/staging/nvec/nvec_paz00.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec_paz00.c
> b/drivers/staging/nvec/nvec_paz00.c index 68146bf..cddbfd2 100644
> --- a/drivers/staging/nvec/nvec_paz00.c
> +++ b/drivers/staging/nvec/nvec_paz00.c
> @@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
> 
>  	platform_set_drvdata(pdev, led);
> 
> -	ret = led_classdev_register(&pdev->dev, &led->cdev);
> +	ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
>  	if (ret < 0)
>  		return ret;
> 
> @@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
> return 0;
>  }
> 
> -static int nvec_paz00_remove(struct platform_device *pdev)
> -{
> -	struct nvec_led *led = platform_get_drvdata(pdev);
> -
> -	led_classdev_unregister(&led->cdev);
> -
> -	return 0;
> -}
> -
>  static struct platform_driver nvec_paz00_driver = {
>  	.probe  = nvec_paz00_probe,
> -	.remove = nvec_paz00_remove,
>  	.driver = {
>  		.name  = "nvec-paz00",
>  	},

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)