linux-kernel - [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3640852.TIcaPixAiA@wuerfel>
Date:	Mon, 25 Jan 2016 23:00:20 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>
Cc:	Johannes Thumshirn <jthumshirn@...e.de>,
	Tina Ruchandani <ruchandani.tina@...il.com>,
	Himanshu Madhani <himanshu.madhani@...gic.com>,
	y2038@...ts.linaro.org, linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...gic.com>
Subject: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

From: Tina Ruchandani <ruchandani.tina@...il.com>

struct register_host_info stores a 64-bit UTC system time timestamp.
This patch removes the use of 'struct timeval' to obtain that timestamp
as its tv_sec value will overflow on 32-bit systems in year 2038 beyond.
The patch uses ktime_get_real_seconds() which returns a 64-bit seconds value.

Signed-off-by: Tina Ruchandani <ruchandani.tina@...il.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
Acked-by: Himanshu Madhani <himanshu.madhani@...gic.com>
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
Resent with correct author field and added Ack

diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index b5029e543b91..15dff7099955 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -6,6 +6,7 @@
  */
 #include "qla_def.h"
 #include <linux/delay.h>
+#include <linux/ktime.h>
 #include <linux/pci.h>
 #include <linux/ratelimit.h>
 #include <linux/vmalloc.h>
@@ -1812,7 +1813,6 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
 	struct host_system_info *phost_info;
 	struct register_host_info *preg_hsi;
 	struct new_utsname *p_sysid = NULL;
-	struct timeval tv;
 
 	sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
 	if (!sp)
@@ -1886,8 +1886,7 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
 			    p_sysid->domainname, DOMNAME_LENGTH);
 			strncpy(phost_info->hostdriver,
 			    QLA2XXX_VERSION, VERSION_LENGTH);
-			do_gettimeofday(&tv);
-			preg_hsi->utc = (uint64_t)tv.tv_sec;
+			preg_hsi->utc = (uint64_t)ktime_get_real_seconds();
 			ql_dbg(ql_dbg_init, vha, 0x0149,
 			    "ISP%04X: Host registration with firmware\n",
 			    ha->pdev->device);