linux-kernel - Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 09:55:53 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Jaehoon Chung <jh80.chung@...sung.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt

On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
> On 2016/1/25 12:14, Jaehoon Chung wrote:
> > Hi, Shawn.
> >
> > On 01/25/2016 10:13 AM, Shawn Lin wrote:
> >> This patch remove repetitive clear interrupt while
> >> probing dw_mmc.
> >
> > Could you explain to me more?
> 
> yes, it's a trivial improvement.
> 
> dw_mci_probe clear interrupt and disable all interrupt firstly.
> Then commit 2da1d7f2 add a new clear-interrupt operation before
> enable some interrupt. I can't see any reason to clear it twice
> here. No any side effect I had found in my test pattern without this
> . May I miss some important case?
> 

The explanation should go into the patch description to explain why
it is done. The one sentence "This patch remove repetitive clear
interrupt while probing dw_mmc" that you wrote instead can be
removed, it just repeats the patch subject.

	Arnd