linux-kernel - Re: [PATCH] reset: hisilicon: check return value of reset_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 11:01:20 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Chen Feng <puck.chen@...ilicon.com>
Subject: Re: [PATCH] reset: hisilicon: check return value of
 reset_controller_register()

Am Sonntag, den 24.01.2016, 01:19 +0900 schrieb Masahiro Yamada:
> The newly added hisilicon reset driver missed the subsystem-wide
> fixup by commit d1f15aa09558 ("reset: check return value of
> reset_controller_register()").  So fix it now.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/reset/hisilicon/hi6220_reset.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 7787a9b..744b2e7 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev)
>  	data->rc_dev.ops = &hi6220_reset_ops;
>  	data->rc_dev.of_node = pdev->dev.of_node;
>  
> -	reset_controller_register(&data->rc_dev);
> -
> -	return 0;
> +	return reset_controller_register(&data->rc_dev);
>  }
>  
>  static const struct of_device_id hi6220_reset_match[] = {

Applied, thanks.

regards
Philipp