linux-kernel - Re: linux-next: build failure after merge of the akpm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 11:19:00 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Mark Brown <broonie@...nel.org>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: linux-next: build failure after merge of the akpm tree

On Mon, 25 Jan 2016 10:40:14 +0100,
Michael Ellerman wrote:
> 
> On Mon, 2016-01-25 at 10:29 +0100, Takashi Iwai wrote:
> > On Fri, 22 Jan 2016 03:40:45 +0100, Stephen Rothwell wrote:
> > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> > > index 50693c867e71..ee5f36b9c787 100644
> > > --- a/sound/soc/codecs/Kconfig
> > > +++ b/sound/soc/codecs/Kconfig
> > > @@ -13,6 +13,7 @@ menu "CODEC drivers"
> > >  config SND_SOC_ALL_CODECS
> > >  	tristate "Build all ASoC CODEC drivers"
> > >  	depends on COMPILE_TEST
> > > +	depends on !PPC
> > >  	select SND_SOC_88PM860X if MFD_88PM860X
> > >  	select SND_SOC_L3
> > >  	select SND_SOC_AB8500_CODEC if ABX500_CORE
> >
> > Suppressing this whole is an overreaction, IMO.  It should suffice
> > just to disable compile-testing Intel driver.
> > How about the patch below?
> >
> >
> > thanks,
> >
> > Takashi
> >
> > -- 8< --
> > From: Takashi Iwai <tiwai@...e.de>
> > Subject: [PATCH] ASoC: intel: suppress compile-test with PowerPC
> >
> > Since some ioctl in compress offload API is broken for PPC (the struct
> > size overflows), now we get actually the build error.
> >
> > Until we get the proper solution (e.g. alternative ioctl), let's
> > disable the build of Intel ASoC driver that is the only driver who
> > enables SND_SOC_COMPRESS (and eventually SND_COMPRESS_OFFLOAD) in the
> > mainline tree.
> >
> > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > ---
> >  sound/soc/intel/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> > index 803f95e40679..d854cd66e090 100644
> > --- a/sound/soc/intel/Kconfig
> > +++ b/sound/soc/intel/Kconfig
> > @@ -31,6 +31,8 @@ config SND_SOC_INTEL_SST
> >  	tristate
> >  	select SND_SOC_INTEL_SST_ACPI if ACPI
> >  	depends on (X86 || COMPILE_TEST)
> > +	# FIXME: a part of compress API is broken for PPC
> > +	depends on !PPC
> >
> >  config SND_SOC_INTEL_SST_ACPI
> >  	tristate
> 
> 
> That's fine by me.
> 
> Acked-by: Michael Ellerman <mpe@...erman.id.au>
> 
> 
> Though it looks like alpha and mips would also be broken, but perhaps they
> can't build that code for some other reason.
> 
>   arch/alpha/include/uapi/asm/ioctl.h:#define _IOC_SIZEBITS       13
>   arch/mips/include/uapi/asm/ioctl.h:#define _IOC_SIZEBITS        13

OK, I'll resubmit the patch including these other archs.


thanks,

Takashi