linux-kernel - Re: [PATCH] drivers/media: vsp1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 09:14:23 -0200
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Anders Roxell <anders.roxell@...aro.org>,
	linux-media@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH] drivers/media: vsp1_video: fix compile error

Em Mon, 25 Jan 2016 00:15:28 +0200
Laurent Pinchart <laurent.pinchart@...asonboard.com> escreveu:

> Hi Anders,
> 
> Thank you for the patch.
> 
> On Friday 15 January 2016 01:09:43 Anders Roxell wrote:
> > This was found with the -RT patch enabled, but the fix should apply to
> > non-RT also.
> > 
> > Compilation error without this fix:
> > ../drivers/media/platform/vsp1/vsp1_video.c: In function
> > 'vsp1_pipeline_stopped':
> > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
> > expression before 'do'
> >   spin_unlock_irqrestore(&pipe->irqlock, flags);
> >     ^
> > 
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> and applied to my tree.

Better to apply this to the fixes branch and send it together with
the next set of patches upstream.

> 
> > ---
> >  drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644
> > --- a/drivers/media/platform/vsp1/vsp1_video.c
> > +++ b/drivers/media/platform/vsp1/vsp1_video.c
> > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline
> > *pipe) bool stopped;
> > 
> >  	spin_lock_irqsave(&pipe->irqlock, flags);
> > -	stopped = pipe->state == VSP1_PIPELINE_STOPPED,
> > +	stopped = pipe->state == VSP1_PIPELINE_STOPPED;
> >  	spin_unlock_irqrestore(&pipe->irqlock, flags);
> > 
> >  	return stopped;
>