linux-kernel - Re: linux-next: build failure after merge of the akpm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 16:48:06 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Mark Brown <broonie@...nel.org>,
	Vinod Koul <vinod.koul@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: linux-next: build failure after merge of the akpm tree

On Mon, Jan 25, 2016 at 12:03:54PM +0100, Takashi Iwai wrote:
> On Mon, 25 Jan 2016 11:45:56 +0100,
> Sudip Mukherjee wrote:
> > 
> > On Mon, Jan 25, 2016 at 10:29:54AM +0100, Takashi Iwai wrote:
> > > On Fri, 22 Jan 2016 03:40:45 +0100,
> > > Stephen Rothwell wrote:
> > > > 
> > > > Hi all,
> > > > 
<snip>
> > > > 
> > > > From: Stephen Rothwell <sfr@...b.auug.org.au>
> > > > Date: Fri, 22 Jan 2016 13:24:57 +1100
> > > > Subject: [PATCH] next: suppress the building of all the sound codecs on PPC
> > > >  for now
> > > > 
> > > > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > > > ---
> > > >  sound/soc/codecs/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> > > > index 50693c867e71..ee5f36b9c787 100644
> > > > --- a/sound/soc/codecs/Kconfig
> > > > +++ b/sound/soc/codecs/Kconfig
> > > > @@ -13,6 +13,7 @@ menu "CODEC drivers"
> > > >  config SND_SOC_ALL_CODECS
> > > >  	tristate "Build all ASoC CODEC drivers"
> > > >  	depends on COMPILE_TEST
> > > > +	depends on !PPC
> > > >  	select SND_SOC_88PM860X if MFD_88PM860X
> > > >  	select SND_SOC_L3
> > > >  	select SND_SOC_AB8500_CODEC if ABX500_CORE
> > > 
> > > Suppressing this whole is an overreaction, IMO.  It should suffice
> > > just to disable compile-testing Intel driver.
> > > How about the patch below?
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > > 
> > > -- 8< --
> > > From: Takashi Iwai <tiwai@...e.de>
> > > Subject: [PATCH] ASoC: intel: suppress compile-test with PowerPC
> > > 
> > > Since some ioctl in compress offload API is broken for PPC (the struct
> > > size overflows), now we get actually the build error.
> > > 
> > > Until we get the proper solution (e.g. alternative ioctl), let's
> > > disable the build of Intel ASoC driver that is the only driver who
> > > enables SND_SOC_COMPRESS (and eventually SND_COMPRESS_OFFLOAD) in the
> > > mainline tree.
> > 
> > Sorry, but this does not fix the build failure.
> > I can still see SND_COMPRESS_OFFLOAD=m in .config and the build fails.
> 
> Who sets this config?  SND_COMPRESS_OFFLOAD has no prompt, so this
> should be default off.

I think when we are doing allmodconfig SND_SOC_COMPRESS will be selected
which in turn will select SND_COMPRESS_OFFLOAD as SND_SOC_COMPRESS
depends only on SND_SOC.

And alpha is not affected. It builds fine.

regards
sudip