linux-kernel - Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160125112936.GB3368@x1>
Date:	Mon, 25 Jan 2016 11:29:36 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linus.walleij@...aro.org, gnurou@...il.com, broonie@...nel.org,
	a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com,
	lgirdwood@...il.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	rtc-linux@...glegroups.com, swarren@...dia.com, treding@...dia.com,
	vreddytalla@...dia.com, Chaitanya Bandi <bandik@...dia.com>,
	Mallikarjun Kasoju <mkasoju@...dia.com>
Subject: Re: [PATCH V4 2/5] mfd: max77620: add core driver for
 MAX77620/MAX20024

On Fri, 22 Jan 2016, Laxman Dewangan wrote:

> Thanks Krzysztof for review.
> 
> Hi Lee,
> Are you taking the patches from your tree? Or will go in individual
> subsystem?

I can take the set if there are build dependencies.  If there aren't,
then they should be routed via their respective subsystem trees.

> On Wednesday 20 January 2016 10:52 AM, Krzysztof Kozlowski wrote:
> >On 19.01.2016 19:19, Laxman Dewangan wrote:
> >>MAX77620/MAX20024 are Power Management IC from the MAXIM.
> >>It supports RTC, multiple GPIOs, multiple DCDC and LDOs,
> >>watchdog, clock etc.
> >>
> >>Add MFD drier to provides common support for accessing the
> >>device; additional drivers is developed on respected subsystem
> >>in order to use the functionality of the device.
> >>
> >>Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> >>Signed-off-by: Chaitanya Bandi <bandik@...dia.com>
> >>Signed-off-by: Mallikarjun Kasoju <mkasoju@...dia.com>
> >>---
> >>Changes from V1:
> >>- Code cleanups per review from V1.
> >>- Move register acccess APIs from header to c file.
> >>- Remove some of non required variable, remove duplication in error message
> >>  and simplify some of function implementation.
> >>- Register RTC driver such that it can get the regmap handle form parent device
> >>
> >>Changes from V2:
> >>- Run coccicheck and checkpatch in strict mode for the alignment.
> >>- Drop RTC driver and its i2c client registration.
> >>
> >>Changes from V3:
> >>- Change all sys initcall to module driver.
> >>- change the max77620_read argument to unisgned int from u8.
> >>
> >>  drivers/mfd/Kconfig          |  15 +
> >>  drivers/mfd/Makefile         |   1 +
> >>  drivers/mfd/max77620.c       | 871 +++++++++++++++++++++++++++++++++++++++++++
> >>  include/linux/mfd/max77620.h | 404 ++++++++++++++++++++
> >>  4 files changed, 1291 insertions(+)
> >>  create mode 100644 drivers/mfd/max77620.c
> >>  create mode 100644 include/linux/mfd/max77620.h
> >>
> >
> >Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> >
> >Best regards,
> >Krzysztof
> >
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog