linux-kernel - Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160125120159.GI3163@localhost>
Date:	Mon, 25 Jan 2016 13:01:59 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial
 private data

On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote:
> On nominal execution, private data allocated on port_probe and attach
> are never freed. Add port_remove and release callbacks to free them
> respectively.
> 
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@...il.com>

I've applied this one for 4.5-rc2 now.

I want to take a closer look at the last three patches and it seems they
should wait for 4.6 anyway. I did notice that the vendor driver also
sends double START/OPEN commands at open by the way. Perhaps ask Moxa
why that is before we remove them?

Thanks,
Johan