linux-kernel - Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 13:19:46 +0100
From:	John Crispin <blogic@...nwrt.org>
To:	Javier Martinez Canillas <javier@...hile0.org>
Cc:	Steven Liu <steven.liu@...iatek.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Henry Chen <henryc.chen@...iatek.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	linux-mediatek@...ts.infradead.org,
	Matthias Brugger <matthias.bgg@...il.com>,
	Chen Zhong <chen.zhong@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323
 regulator

Hi,

On 25/01/2016 13:11, Javier Martinez Canillas wrote:
> Hello,
> 
> On Mon, Jan 25, 2016 at 7:40 AM, John Crispin <blogic@...nwrt.org> wrote:
>> From: Chen Zhong <chen.zhong@...iatek.com>
> 
> [snip]
> 
>> +}
>> +
>> +static struct platform_driver mt6323_regulator_driver = {
>> +       .driver = {
>> +               .name = "mt6323-regulator",
>> +       },
>> +       .probe = mt6323_regulator_probe,
>> +};
>> +
> 
> You don't have a .of_match table but according the DT bindings, the
> compatible string "mediatek,mt6323-regulator" should be used so there
> should be a OF match table or the vendor prefix of the compatible
> string won't be used for matching (i.e: fallbacks to the driver .name
> for match).

the driver is probed via drivers/mfd/mt6397-core.c and does not require
the OF match table. It loads fine just like the mt6397 driver.

> 
>> +module_platform_driver(mt6323_regulator_driver);
>> +
>> +MODULE_AUTHOR("Chen Zhong <chen.zhong@...iatek.com>");
>> +MODULE_DESCRIPTION("Regulator Driver for MediaTek MT6397 PMIC");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:mt6323-regulator");
> 
> This alias should not be needed if you provide a OF match table and a
> MODULE_DEVICE_TABLE(of, foo);

see above.

	John