linux-kernel - Re: [Patch V2 2/9] clk: tegra210: Remove improper flags for lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160125123412.GE20452@ulmo.nvidia.com>
Date:	Mon, 25 Jan 2016 13:34:12 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch V2 2/9] clk: tegra210: Remove improper flags for
 lock_enable

On Thu, Jan 14, 2016 at 02:24:31PM -0500, Rhyland Klein wrote:
> Most PLL's don't actually have LOCK_ENABLE bits. However, most PLL's
> also had that flag set, which meant that the clk code was trying to
> enable locks, and inadvertantly flipping bits in other fields.
> 
> For PLLM, ensure the correct register is used for the misc_register.
> PLL_MISC0 contains the EN_LCKDET bit which should be used for enabling
> the lock, and PLLM_MISC1 shouldn't be used at all.
> 
> Lastly, remove some of the settings which would point to the EN_LCKDET
> bits for some PLLs. There is no need to enable the locks, and that is
> done as part of the set_defaults logic already.
> 
> Signed-off-by: Rhyland Klein <rklein@...dia.com>
> ---
>  drivers/clk/tegra/clk-tegra210.c | 42 ++++++++++++++--------------------------
>  1 file changed, 14 insertions(+), 28 deletions(-)

It seems like this could've been split into several patches given the
three different changes above. However since they all seem to relate to
the lock enable behaviour I've gone and applied this as is.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)