linux-kernel - Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160125135109.760ba5f0@ipc1.ka-ro>
Date:	Mon, 25 Jan 2016 13:51:09 +0100
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	Benoît Cousson <bcousson@...libre.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional

Hi,

On Mon, 25 Jan 2016 12:41:23 +0000 Mark Brown wrote:
> On Mon, Jan 25, 2016 at 01:37:31PM +0100, Lothar Waßmann wrote:
> > On Fri, 22 Jan 2016 16:26:10 +0000 Mark Brown wrote:
> 
> > > You're not just making the interrupt optional, you are also implementing
> > > polling support.  That's really unusual and there's no clear reason for
> 
> > Any suggestions how to handle this case in a more sensible way?
> 
> The above, for example - make the interrupt optional.
>
This will make it impossible to notify the system about
overtemperature (and undervoltage).
I implemented polling to be able to get at least overtemperature
warnings.
(Undervoltage cannot be handled sensibly without interrupt anyway)


Lothar Waßmann