linux-kernel - Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160125125356.GO3368@x1>
Date:	Mon, 25 Jan 2016 12:53:56 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	linux-kernel@...r.kernel.org, lgirdwood@...il.com,
	broonie@...nel.org, yudongbin@...ilicon.com,
	saberlily.xia@...ilicon.com, suzhuangluan@...ilicon.com,
	kong.kongxinwei@...ilicon.com, xuyiping@...ilicon.com,
	z.liuxinliang@...ilicon.com, puck.chenfeng@...il.com,
	weidong2@...ilicon.com, w.f@...wei.com, qijiwen@...ilicon.com,
	peter.panshilin@...ilicon.com, dan.zhao@...ilicon.com,
	linuxarm@...wei.com, liguozhu@...ilicon.com
Subject: Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC

On Mon, 11 Jan 2016, Chen Feng wrote:

> Add document for mfd driver hi655x pmic driver
> 
> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> Signed-off-by: Fei Wang <w.f@...wei.com>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com>
> ---
>  .../devicetree/bindings/mfd/hisilicon,hi655x.txt   | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> new file mode 100644
> index 0000000..3180c40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> @@ -0,0 +1,28 @@
> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
> +
> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
> +We can use memory-mapped I/O to communicate.
> +
> ++----------------+             +-------------+
> +|                |             |             |
> +|    Hi6220      |   SSI bus   |   Hi655x    |
> +|                |-------------|             |
> +|                |(REGMAP_MMIO)|             |
> ++----------------+             +-------------+
> +
> +Required properties:
> +- compatible: Should be "hisilicon,hi655x-pmic"
> +- reg: Base address of PMIC on hi6220 soc

SoC

> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
> +- pmic-gpios: The gpio used by pmic irq.

PMIC IRQ

> +
> +Example:
> +	pmic: pmic@...00000 {
> +		compatible = "hisilicon,hi655x-pmic";
> +		reg = <0x0 0xf8000000 0x0 0x1000>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		pmic-gpios = <&gpio1 2 0>;

What's the last cell for here?  If they are flags, there is probably a
#define you can use in dt-include.

> +		status = "disabled";

What's the point in disabling example code?

> +	}

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog