linux-kernel - Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 10:25:03 -0300
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	John Crispin <blogic@...nwrt.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Steven Liu <steven.liu@...iatek.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Henry Chen <henryc.chen@...iatek.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-mediatek@...ts.infradead.org,
	Matthias Brugger <matthias.bgg@...il.com>,
	Chen Zhong <chen.zhong@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator

On Mon, Jan 25, 2016 at 10:19 AM, Javier Martinez Canillas
<javier@...hile0.org> wrote:

[snip]

>
> In fact, the kernel is currently not matching the compatible, it is
> only matching because you provided a .of_compatible is provided in the
> mfd_cell.
>

Sorry my English was a bit off in this paragraph...

I tried to say that OF does not traverse MFD sub-devices and lookups a
device driver that matches the compatible automatically since a MFD
device is not a bus. Currently it is only trying to match a compatible
string because the mfd_cell has a .of_compatible set so an of_node is
assigned on mfd_add_device().

But it is failing to match because no OF device table is provided and
the platform bus match callback is falling back to the driver .name to
match so the compatible is not really used as Mark said.

Best regards,
Javier