linux-kernel - Re: [PATCH v2] of: drop symbols declared by _OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+gk81AYJsPoMtLdXqoXs_q6p=gsa476PObCB8kqYsm=Q@mail.gmail.com>
Date:	Mon, 25 Jan 2016 08:54:16 -0600
From:	Rob Herring <robh@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Peter Hurley <peter@...leysoftware.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Frank Rowand <frowand.list@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules

On Thu, Jan 21, 2016 at 10:33 AM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> The users of this macro (OF_EARLYCON_DECLARE, CLK_OF_DECLARE,
> IRQCHIP_DECLARE, etc.) are only parsed in the early boot stage.
> Such symbols contained in modules are never used.
>
> This commit fixes the link error introduced by commit b8d20e06eaad
> ("serial: 8250_uniphier: add earlycon support"); the combination
> of CONFIG_SERIAL_8250_UNIPHIER=m and CONFIG_SERIAL_8250_CONSOLE=y
> fails to link:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> ---
>
> Changes in v2:
>   - Describe the bug fixed by this commit
>
>  include/linux/of.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Rob