linux-kernel - Re: [PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1453734204.17181.15.camel@tiscali.nl>
Date:	Mon, 25 Jan 2016 16:03:24 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	peterz@...radead.org, heiko.carstens@...ibm.com,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-arch@...r.kernel.org, Joonsoo Kim <iamjoonsoo.kim@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/debug_pagealloc: Ask users for default setting of
 debug_pagealloc

On ma, 2016-01-25 at 12:15 +0100, Christian Borntraeger wrote:
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug

> +config DEBUG_PAGEALLOC_ENABLE_DEFAULT
> +	bool "Enable debug page memory allocations by default?"
> +        default off

Nit: you apparently meant
	default n

Note that "default off" should also evaluate to "n", which probably
explains why you didn't notice. And "n" is the default anyhow.

So I'm guessing you might as well drop this line.

> +        depends on DEBUG_PAGEALLOC
> +        ---help---
> +	  Enable debug page memory allocations by default? This value
> +	  can be overridden by debug_pagealloc=off|on.
> +
> +	  If unsure say no.

(Really trivial: you start indentation both with spaces and with tabs.
Start with tabs, please.)


Paul Bolle