linux-kernel - Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A64B0C.2010809@arm.com>
Date:	Mon, 25 Jan 2016 16:19:24 +0000
From:	Marc Zyngier <marc.zyngier@....com>
To:	Arnd Bergmann <arnd@...db.de>, Jason Cooper <jason@...edaemon.net>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused

On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
> 
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
> 
> This marks the array as __maybe_unused to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/irqchip/irq-s3c24xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
>  	return ERR_PTR(ret);
>  }
>  
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
> 

Acked-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...