linux-kernel - Re: [PATCH] ix86: fix types used in pgprot cachability flags translations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1601251757440.3886@nanos>
Date:	Mon, 25 Jan 2016 17:59:06 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jan Beulich <JBeulich@...e.com>
cc:	mingo@...e.hu, hpa@...or.com, Juergen Gross <JGross@...e.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ix86: fix types used in pgprot cachability flags
 translations

On Mon, 25 Jan 2016, Jan Beulich wrote:

> For PAE kernels "unsigned long" is not suitable to hold page protection
> flags, since _PAGE_NX doesn't fit there. This is the reason for quite a
> few W+X pages getting reported as insecure during boot (observed namely
> for the entire initrd range).
> 
> Quite the other way around, "unsigned long" is inefficient for 64-bit
> kernels when dealing with cachability flags alone - "unsigned int" is
> sufficient here and allows for slightly smaller code to be generated.

This part has nothing to do with the fix. Can you please avoid to mix fixes,
which require backporting and code enhancements?

Thanks,

	tglx