linux-kernel - Re: [PATCH] ARM: bcm: use const and __initconst for smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A65841.1040100@broadcom.com>
Date:	Mon, 25 Jan 2016 09:15:45 -0800
From:	Ray Jui <rjui@...adcom.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Scott Branden <sbranden@...adcom.com>,
	<linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	<bcm-kernel-feedback-list@...adcom.com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ARM: bcm: use const and __initconst for smp_operations

Hi Masahiro,

On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
> This newly added code missed the global fixup by commit 75305275a721
> ("ARM: use const and __initconst for smp_operations").  So fix it now.
>
> Also, add missing "static" qualifier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>   arch/arm/mach-bcm/platsmp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 575defc..cfae9c7 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
>   CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
>   			&bcm_smp_ops);
>
> -struct smp_operations nsp_smp_ops __initdata = {
> +static const struct smp_operations nsp_smp_ops __initconst = {
>   	.smp_prepare_cpus	= bcm_smp_prepare_cpus,
>   	.smp_boot_secondary	= nsp_boot_secondary,
>   };
>

This fix looks good to me. Thanks!

Reviewed-by: Ray Jui <rjui@...adcom.com>