linux-kernel - Re: [PATCH v3] mm: warn about VmData over RLIMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 14:49:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Konstantin Khlebnikov <koct9i@...il.com>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>, linux-mm@...ck.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Vegard Nossum <vegard.nossum@...cle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Vladimir Davydov <vdavydov@...tuozzo.com>,
	Andy Lutomirski <luto@...capital.net>,
	Quentin Casasnovas <quentin.casasnovas@...cle.com>,
	Kees Cook <keescook@...gle.com>, Willy Tarreau <w@....eu>,
	Pavel Emelyanov <xemul@...tuozzo.com>
Subject: Re: [PATCH v3] mm: warn about VmData over RLIMIT_DATA

On Sat, 23 Jan 2016 23:52:29 +0300 Konstantin Khlebnikov <koct9i@...il.com> wrote:

> This patch fixes 84638335900f ("mm: rework virtual memory accounting")

uh, I think I'll rewrite this to

: This patch provides a way of working around a slight regression introduced
: by 84638335900f ("mm: rework virtual memory accounting").

> Before that commit RLIMIT_DATA have control only over size of the brk region.
> But that change have caused problems with all existing versions of valgrind,
> because it set RLIMIT_DATA to zero.
> 
> This patch fixes rlimit check (limit actually in bytes, not pages)
> and by default turns it into warning which prints at first VmData misuse:
> "mmap: top (795): VmData 516096 exceed data ulimit 512000. Will be forbidden soon."
> 
> Behavior is controlled by boot param ignore_rlimit_data=y/n and by sysfs
> /sys/module/kernel/parameters/ignore_rlimit_data. For now it set to "y".
> 
> 
> ...
>
> +static inline bool is_data_mapping(vm_flags_t flags)
> +{
> +	return (flags & ((VM_STACK_FLAGS & (VM_GROWSUP | VM_GROWSDOWN)) |
> +					VM_WRITE | VM_SHARED)) == VM_WRITE;
> +}

This (copied from existing code) hurts my brain.  We're saying "if it
isn't stack and it's unshared and writable, it's data", yes?

hm.  I guess that's because with a shared mapping we don't know who to
blame for the memory consumption so we blame nobody.  But what about
non-shared read-only mappings?

Can we please have a comment here fully explaining the thinking?