linux-kernel - Re: [PATCH/RFC 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1601261521560.25141@chino.kir.corp.google.com>
Date:	Tue, 26 Jan 2016 15:23:26 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Christian Borntraeger <borntraeger@...ibm.com>
cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-mm@...ck.org, linux-arch@...r.kernel.org,
	linux-s390@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH/RFC 1/3] mm: provide debug_pagealloc_enabled() without
 CONFIG_DEBUG_PAGEALLOC

On Tue, 26 Jan 2016, Christian Borntraeger wrote:

> We can provide debug_pagealloc_enabled() also if CONFIG_DEBUG_PAGEALLOC
> is not set. It will return false in that case.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@...ibm.com>
> ---
>  include/linux/mm.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 7783073..fbc5354 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2148,6 +2148,10 @@ kernel_map_pages(struct page *page, int numpages, int enable)
>  extern bool kernel_page_present(struct page *page);
>  #endif /* CONFIG_HIBERNATION */
>  #else
> +static inline bool debug_pagealloc_enabled(void)
> +{
> +	return false;
> +}
>  static inline void
>  kernel_map_pages(struct page *page, int numpages, int enable) {}
>  #ifdef CONFIG_HIBERNATION

Since the patchset needs to be refreshed based on Heiko and Thomas's 
comments, please add some /* CONFIG_DEBUG_PAGEALLOC */ annotation to the 
#else and #endif lines so this block is easier to read.  After that, feel 
free to add

	Acked-by: David Rientjes <rientjes@...gle.com>