linux-kernel - Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 15:34:07 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org
CC:	user-mode-linux-devel@...ts.sourceforge.net,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Moritz Fischer <moritz.fischer@...us.com>,
	Jun Nie <jun.nie@...aro.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs

On 25/01/16 14:24, Richard Weinberger wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  drivers/power/reset/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 1131cf7..0a6408a 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>  config POWER_RESET_SYSCON
>  	bool "Generic SYSCON regmap reset driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
does not issue I/O accesses per-se, but does use helpers from regmap,
which in turn do it.

>  	help
>  	  Reboot support for generic SYSCON mapped register reset.
> @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON
>  config POWER_RESET_SYSCON_POWEROFF
>  	bool "Generic SYSCON regmap poweroff driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Likewise.
-- 
Florian