linux-kernel - Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160126081335.GA8534@gmail.com>
Date:	Tue, 26 Jan 2016 09:13:35 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Mel Gorman <mgorman@...hsingularity.net>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Mike Galbraith <mgalbraith@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] sched: Make schedstats a runtime tunable that is
 disabled by default


* Mel Gorman <mgorman@...hsingularity.net> wrote:

> -	ttwu_stat(p, smp_processor_id(), 0);
> +	if (schedstat_enabled())
> +		ttwu_stat(p, smp_processor_id(), 0);

Yeah. I actually like this for the cleanup factor as well: your patch makes it a 
_lot_ more obvious what is a statistics slowpath and what is not.

We tried to achieve that effect via the _stat() naming, but in hindsight that was 
a failure.

Thanks,

	Ingo