linux-kernel - Re: [PATCH v2] ata: add AMD Seattle platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 10:36:57 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Tejun Heo <tj@...nel.org>, Brijesh Singh <brijesh.singh@....com>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver

Hi,

On 25-01-16 21:43, Tejun Heo wrote:
> On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote:
>> AMD Seattle SATA controller mostly conforms to AHCI interface with some
>> special register to control SGPIO interface. In the case of an AHCI
>> controller, the SGPIO feature is ideally implemented using the
>> "Enclosure Management" register of the AHCI controller, but those
>> registeres are not implemented in the Seattle SoC. Instead SoC
>> (Rev B0 onwards) provides a 32-bit SGPIO control register which should
>> be programmed to control the activity, locate and fault LEDs.
>>
>> The driver is based on ahci_platform driver.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@....com>
>> Acked-by: Hans de Goede <hdegoede@...hat.com>
>> CC: tj@...nel.org
>> CC: linux-ide@...r.kernel.org
>
> Hans, can you please review the patch?

Done, driver looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans