linux-kernel - Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A74AF6.90307@nod.at>
Date:	Tue, 26 Jan 2016 11:31:18 +0100
From:	Richard Weinberger <richard@....at>
To:	John Garry <john.garry@...wei.com>, linux-kernel@...r.kernel.org
Cc:	user-mode-linux-devel@...ts.sourceforge.net,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA
 archs

Am 26.01.2016 um 11:15 schrieb John Garry:
> On 25/01/2016 22:24, Richard Weinberger wrote:
>> Not every arch has io or DMA memory.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>>   drivers/scsi/hisi_sas/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
>> index 37a0c71..f9157f4 100644
>> --- a/drivers/scsi/hisi_sas/Kconfig
>> +++ b/drivers/scsi/hisi_sas/Kconfig
>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS
>>       tristate "HiSilicon SAS"
>>       select SCSI_SAS_LIBSAS
>>       select BLK_DEV_INTEGRITY
>> +    depends on HAS_IOMEM && HAS_DMA
>>       help
>>           This driver supports HiSilicon's SAS HBA
>>
> 
> I think that there is already a fix for depencencies from Geert:
> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes

Hmm, right. But we still need HAS_IOMEM too.

Thanks,
//richard