linux-kernel - Re: [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1601261117200.3619@kaball.uk.xensource.com>
Date:	Tue, 26 Jan 2016 11:31:19 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Shannon Zhao <zhaoshenglong@...wei.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<ard.biesheuvel@...aro.org>, <mark.rutland@....com>,
	<stefano.stabellini@...rix.com>, <david.vrabel@...rix.com>,
	<catalin.marinas@....com>, <will.deacon@....com>,
	<julien.grall@...rix.com>, <xen-devel@...ts.xen.org>,
	<devicetree@...r.kernel.org>, <linux-efi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <ian.campbell@...rix.com>,
	<shannon.zhao@...aro.org>, <peter.huangpeng@...wei.com>
Subject: Re: [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture
 directory

On Tue, 26 Jan 2016, Shannon Zhao wrote:
> On 2016/1/26 0:44, Stefano Stabellini wrote:
> > On Sat, 23 Jan 2016, Shannon Zhao wrote:
> >> > From: Shannon Zhao <shannon.zhao@...aro.org>
> >> > 
> >> > Move x86 specific codes to architecture directory and export those EFI
> >> > runtime service functions. This will be useful for initializing runtime
> >> > service on ARM later.
> >> > 
> >> > Signed-off-by: Shannon Zhao <shannon.zhao@...aro.org>
> > This patch causes a build breakage on x86:
> > 
> > arch/x86/xen/efi.c: In function ‘xen_efi_probe’:
> > arch/x86/xen/efi.c:101:2: error: implicit declaration of function ‘HYPERVISOR_platform_op’ [-Werror=implicit-function-declaration]
> > 
> This patch is based on following patch [1]. Maybe you need to update
> your branch. :)
> 
> [1] xen: rename dom0_op to platform_op
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=cfafae940381207d48b11a73a211142dba5947d3

Sorry, I made a mistake rebasing the series. It doesn't help that I
couldn't find any Linux RCs on top of which it applies cleanly. As Linus
tags RCs often enough, it is usually helpful to base one's work on a tag
so that it is easier for other people to work on it.

Please add my Reviewed-by to this patch.