linux-kernel - Re: [PATCH] Revert "regmap-mmio: Use native endianness for read/write"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160126113652.GC6588@sirena.org.uk>
Date:	Tue, 26 Jan 2016 11:36:52 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Arnd Bergmann <arnd@...db.de>, Simon Arlott <simon@...e.lp0.eu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "regmap-mmio: Use native endianness for
 read/write"

On Tue, Jan 26, 2016 at 10:24:22AM +0100, Johannes Berg wrote:
> On Tue, 2016-01-26 at 10:09 +0100, Arnd Bergmann wrote:

> > However, we have some freedom at the regmap-mmio level, which we can
> > sanitize in 4.6 if we want to make it more consistent with the rest
> > of regmap. We have around 50 callers of {devm_,}regmap_init_mmio()
> > and almost all of them do not specify endianess but expect little-
> > endian behavior. We can change all existing instances to set
> > REGMAP_ENDIAN_NATIVE explicitly and change regmap_init_mmio() to
> > return an error if the caller does not specify a particular endianess
> > (big, little, native). 

> I'm not sure that we can, since regmap also takes the value from the DT
> directly, and it seems that a driver passing it would mean the DT value
> is no longer honoured?

DT should override the value in the driver rather than the other way
around.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)