linux-kernel - Re: [PATCH 07/12] perf hists browser: Fix callchain_node__count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160126123208.GA24496@danjae.kornet>
Date:	Tue, 26 Jan 2016 21:32:08 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 07/12] perf hists browser: Fix
 callchain_node__count_rows()

Hi Jiri,

On Tue, Jan 26, 2016 at 12:46:38PM +0100, Jiri Olsa wrote:
> On Sun, Jan 24, 2016 at 10:53:30PM +0900, Namhyung Kim wrote:
> > Like other functions, it should stop counting if there's any folded
> > callchain.  Because of this it occasionally lose the cursor at the end.
> 
> are you reffering to the case when the browser wouldn't jump
> to the last entry, but the cursor disappears instead, and then
> shows up after holding 'UP' arrow?  

Right.  Since it counts some of folded callchain nodes, the cursor
went beyond the end so nothing was shown for them.

> 
> because I've seen that occasionaly ;-)

Me too.

Thanks,
Namhyung