linux-kernel - Re: [PATCH] Revert "regmap-mmio: Use native endianness for read/write"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2829394.8U4Fl4Zf7k@wuerfel>
Date:	Tue, 26 Jan 2016 14:16:16 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Simon Arlott <simon@...e.lp0.eu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "regmap-mmio: Use native endianness for read/write"

On Tuesday 26 January 2016 11:36:52 Mark Brown wrote:
> On Tue, Jan 26, 2016 at 10:24:22AM +0100, Johannes Berg wrote:
> > On Tue, 2016-01-26 at 10:09 +0100, Arnd Bergmann wrote:
> 
> > > However, we have some freedom at the regmap-mmio level, which we can
> > > sanitize in 4.6 if we want to make it more consistent with the rest
> > > of regmap. We have around 50 callers of {devm_,}regmap_init_mmio()
> > > and almost all of them do not specify endianess but expect little-
> > > endian behavior. We can change all existing instances to set
> > > REGMAP_ENDIAN_NATIVE explicitly and change regmap_init_mmio() to
> > > return an error if the caller does not specify a particular endianess
> > > (big, little, native). 
> 
> > I'm not sure that we can, since regmap also takes the value from the DT
> > directly, and it seems that a driver passing it would mean the DT value
> > is no longer honoured?
> 
> DT should override the value in the driver rather than the other way
> around.

So if we default to little-endian for all regmap-mmio mappings, and let
the driver or DT override that, and the regmap core already has the
logic to read the ordering from DT, should we remove the parsing of 
the byteorder attributes from syscon and just let regmap do its thing?

I was thinking about adding the patch below, but it sounds like we can
just remove the parsing completely.

	Arnd


diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index b7aabeefab07..69d9bb84c94a 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -64,10 +64,13 @@ static struct syscon *of_syscon_register(struct device_node *np)
 		goto err_map;
 	}
 
-	/* Parse the device's DT node for an endianness specification */
+	/* Parse the device's DT node for an endianness specification,
+	   default to little-endian on all architectures */
 	if (of_property_read_bool(np, "big-endian"))
 		syscon_config.val_format_endian = REGMAP_ENDIAN_BIG;
-	 else if (of_property_read_bool(np, "little-endian"))
+	else if (of_property_read_bool(np, "native-endian"))
+		syscon_config.val_format_endian = REGMAP_ENDIAN_NATIVE;
+	else
 		syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE;
 
 	/*