linux-kernel - Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160126022531.GA23394@hr-amur2>
Date:	Tue, 26 Jan 2016 10:25:31 +0800
From:	Huang Rui <ray.huang@....com>
To:	Gioh Kim <gi-oh.kim@...fitbricks.com>,
	Guenter Roeck <linux@...ck-us.net>
CC:	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Borislav Petkov" <bp@...en8.de>
Subject: Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote:
> The bits [31:29] of D18F5xE8 TDP Limit3 are reserved.
> I think it'd better to add masking to read ApmTdpLimit[28:16] precisely.
> 
> Signed-off-by: Gioh Kim <gi-oh.kim@...fitbricks.com>
> ---
>  drivers/hwmon/fam15h_power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
> index f77eb97..f9647c8 100644
> --- a/drivers/hwmon/fam15h_power.c
> +++ b/drivers/hwmon/fam15h_power.c
> @@ -90,7 +90,7 @@ static ssize_t show_power(struct device *dev,
>  	pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
>  				  REG_TDP_LIMIT3, &val);
>  
> -	tdp_limit = val >> 16;
> +	tdp_limit = (val >> 16) & 0x1fff;


Thanks to send the patch on fam15h_power driver. :-)
In latest AMD (family 15h, Model 60h) processor, ApmTdpLimit field is
expanded to [32:16]. The orignal reserved bits actually are reserved
for ApmTdpLimit expansion.

http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf

Guenter, Will I collect all patches of fam15h_power and send them to
you, or ack it that you can apply directly?

Thanks,
Rui