linux-kernel - Re: mm: WARNING in __delete_from_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 14:36:36 +0100
From:	Jan Kara <jack@...e.cz>
To:	Matthew Wilcox <willy@...ux.intel.com>
Cc:	"Williams, Dan J" <dan.j.williams@...el.com>,
	"kirill@...temov.name" <kirill@...temov.name>,
	"jack@...e.cz" <jack@...e.cz>,
	"syzkaller@...glegroups.com" <syzkaller@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"kcc@...gle.com" <kcc@...gle.com>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"dvyukov@...gle.com" <dvyukov@...gle.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"gthelen@...gle.com" <gthelen@...gle.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"mhocko@...e.com" <mhocko@...e.com>,
	"jack@...e.com" <jack@...e.com>,
	"glider@...gle.com" <glider@...gle.com>,
	"sasha.levin@...cle.com" <sasha.levin@...cle.com>,
	"Wilcox, Matthew R" <matthew.r.wilcox@...el.com>,
	"j-nomura@...jp.nec.com" <j-nomura@...jp.nec.com>
Subject: Re: mm: WARNING in __delete_from_page_cache

On Tue 26-01-16 07:54:56, Matthew Wilcox wrote:
> On Tue, Jan 26, 2016 at 03:42:34AM +0000, Williams, Dan J wrote:
> > @@ -2907,7 +2912,12 @@ extern void replace_mount_options(struct super_block *sb, char *options);
> >  
> >  static inline bool io_is_direct(struct file *filp)
> >  {
> > -	return (filp->f_flags & O_DIRECT) || IS_DAX(file_inode(filp));
> 
> I think this should just be a one-liner:
> 
> -	return (filp->f_flags & O_DIRECT) || IS_DAX(file_inode(filp));
> +	return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
> 
> This does the right thing for block device inodes and filesystem inodes.
> (see the opening stanzas of __dax_fault for an example).

Ah, right. This looks indeed better.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR