linux-kernel - Re: [PATCH] checkpatch: fix left brace warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGG-pUSy+i5Yn_Ba5JeWvG76JLR-+CTJu=LYDLaT3qf=AxYyXg@mail.gmail.com>
Date:	Tue, 26 Jan 2016 11:50:57 -0300
From:	"Geyslan G. Bem" <geyslan@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] checkpatch: fix left brace warning

Hello,

2015-12-30 12:49 GMT-03:00 Geyslan G. Bem <geyslan@...il.com>:
> This patch escapes a regex that uses left brace.
>
> Using checkpatch.pl with Perl 5.22.0 generates the warning: "Unescaped
> left brace in regex is deprecated, passed through in regex;"
>
> Comment from regcomp.c in Perl source: "Currently we don't warn when the
> lbrace is at the start of a construct. This catches it in the middle of
> a literal string, or when it's the first thing after something like
> "\b"."
>
> This works as a complement to 4e5d56bd.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> Suggested-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d4960f7..3e11a30 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4108,7 +4108,7 @@ sub process {
>  ##             }
>
>  #need space before brace following if, while, etc
> -               if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\){/) ||
> +               if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\)\{/) ||
>                     $line =~ /do\{/) {
>                         if (ERROR("SPACING",
>                                   "space required before the open brace '{'\n" . $herecurr) &&
> --
> 2.6.4
>

This was acked?


-- 
Regards,

Geyslan G. Bem
hackingbits.com