linux-kernel - Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160126024157.GA15270@rob-hp-laptop>
Date:	Mon, 25 Jan 2016 20:41:57 -0600
From:	Rob Herring <robh@...nel.org>
To:	Wei Ni <wni@...dia.com>
Cc:	thierry.reding@...il.com, rui.zhang@...el.com,
	MLongnecker@...dia.com, swarren@...dotorg.org,
	mikko.perttunen@...si.fi, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm

On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
> Add hw-trips sub-node for soctherm, which is
> used to describe the hardware trip points for
> each soctherm sensors.

This seems like something that should be common. There was a hwmon 
binding just the other day with temperature set points.

> Signed-off-by: Wei Ni <wni@...dia.com>
> ---
>  .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> index 6b68cd150405..75dc9dbe7e1a 100644
> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> @@ -26,6 +26,15 @@ Required properties :
>      of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a
>      list of valid values when referring to thermal sensors.
>  
> +Optional properties:
> +- hw-trip-points : A sub-node which is a container of hardware trip points
> +    for each sensors.
> +  * sensors: Sub-nodes which are used to describe the HW trip points info,
> +        must be named as "cpu", "gpu", "mem", "pll".
> +      Properties:
> +      - thermtrip-temperature : Shutdown or reset temperature in millicelsius,
> +        once the temperature of this sensor is higher than the
> +        thermtrip-temperature, the system will be shutdown or reset.

Append units and temperature is a bit redundant. Something like 
thermtrip-mC or thermtrip-milliC

You could easily have multiple levels of trip points, so perhaps the 
name needs to reflect the action (i.e. shutdown).

Rob