linux-kernel - Re: [PATCH] regulator: core: Clear constraints pointer after free on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 15:57:32 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
	<patches@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: core: Clear constraints pointer after free on
 error path

On Tue, Jan 26, 2016 at 03:34:54PM +0000, Mark Brown wrote:
> On Tue, Jan 26, 2016 at 03:14:16PM +0000, Charles Keepax wrote:
> 
> > As we now free the constraints in regulator_dev_release we will still
> > call free on the constraints pointer even if we went down an error path
> > in regulator_register, as such we need to clear to the pointer to ensure
> > the kfree in regulator_dev_release is a no-op.
> 
> No, this is just making things worse - if we're doing the free in the
> release we should be doing the free in the release not sometimes maybey
> in the release.

Fair enough I will respin to remove the other free's.

Thanks,
Charles