lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160126161518.GA27589@krava.brq.redhat.com>
Date:	Tue, 26 Jan 2016 17:15:18 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains

On Wed, Jan 27, 2016 at 12:54:17AM +0900, Namhyung Kim wrote:

SNIP

> > > > > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable              
> > > > > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write       
> > > > > > 
> > > > > 
> > > > > What's the problem?  Now by default callchains under 0.5% (absolute)
> > > > > will not be shown.  I think this is intended output, and we need to
> > > > > consider changing the default percent limit.
> > > > 
> > > > hm, just the TUI shows +- for entries with no callchain
> > > 
> > > Humm, this is an old bug, never got around to try to fix it, or is this
> > > something you were not experiencing before this patchkit from Namhyung?
> > > 
> > 
> > well, there were callchains present before this patchset ;-)
> 
> That is because we apply percent limit to callchains now, and the
> default is 0.5%.  Before this patchset percent limit seems not applied
> so you saw the callchains under the limit.

I'm just saying that in TUI I see entries without callcains (which are filtered out)
but those entries are still marked with +- ... I dont know if that's some old issue

thanks,
jirka


---
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_pmu_enable.part.87                                                              ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_context_sched_in                                                          ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_exec                                                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] setup_new_exec                                                                       ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] load_elf_binary                                                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] search_binary_handler                                                                ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] do_execveat_common.isra.33                                                           ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] sys_execve                                                                           ▒
-    0.08%     0.00%  perf     [kernel.vmlinux]  [k] return_from_execve                                                                   ▒
-    0.08%     0.00%  perf     [unknown]         [k] 0x00007f2175b35e07                                                                   ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_nmi_handler                                                               ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] nmi_handle                                                                           ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] default_do_nmi                                                                       ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] do_nmi                                                                               ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] end_repeat_nmi                                                                       ▒
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable                                                                       ▒
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write                                                                ▒

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ