| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAFpQJXXtrZk19XBM=BTGZMgtNy-xppoG7NZ_nDAv=Nt5P62e6g@mail.gmail.com>
Date: Tue, 26 Jan 2016 22:46:10 +0530
From: Ganapatrao Kulkarni <gpkulkarni@...il.com>
To: Rob Herring <robh@...nel.org>, Mark Rutland <mark.rutland@....com>
Cc: Ganapatrao Kulkarni <gkulkarni@...iumnetworks.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-pci@...r.kernel.org, linux-ia64@...r.kernel.org,
linux-metag@...r.kernel.org,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
linux-arch@...r.kernel.org, Will Deacon <Will.Deacon@....com>,
Catalin Marinas <catalin.marinas@....com>,
Grant Likely <grant.likely@...aro.org>,
Leif Lindholm <leif.lindholm@...aro.org>, rfranz@...ium.com,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
"msalter@...hat.com" <msalter@...hat.com>,
Steve Capper <steve.capper@...aro.org>,
Hanjun Guo <hanjun.guo@...aro.org>,
Al Stone <al.stone@...aro.org>, Arnd Bergmann <arnd@...db.de>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>,
Marc Zyngier <marc.zyngier@....com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Bjorn Helgaas <bhelgaas@...gle.com>, tony.luck@...el.com,
fenghua.yu@...el.com, james.hogan@...tec.com,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
"tglx@...utronix.de" <tglx@...utronix.de>, mingo@...hat.com,
hpa@...or.com, x86@...nel.org,
Jon Masters <jonathan@...masters.org>,
Robert Richter <rrichter@...ium.com>,
Prasun Kapoor <Prasun.Kapoor@...iumnetworks.com>
Subject: Re: [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa.
Hi Rob, Mark,
On Wed, Jan 20, 2016 at 7:48 PM, Rob Herring <robh@...nel.org> wrote:
> On Mon, Jan 18, 2016 at 10:06:01PM +0530, Ganapatrao Kulkarni wrote:
>> DT bindings for numa mapping of memory, cores and IOs.
>>
>> Reviewed-by: Robert Richter <rrichter@...ium.com>
>> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@...iumnetworks.com>
>> ---
>> Documentation/devicetree/bindings/arm/numa.txt | 272 +++++++++++++++++++++++++
>> 1 file changed, 272 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/numa.txt
>
> This is looks okay to me, but some cosmetic things on the example.
can i have your Ack please?
>
>> +==============================================================================
>> +4 - Example dts
>> +==============================================================================
>> +
>> +2 sockets system consists of 2 boards connected through ccn bus and
>> +each board having one socket/soc of 8 cpus, memory and pci bus.
>> +
>> + memory@...00000 {
>
> Drop the leading 0s on unit addresses.
i will correct these in next version.
>
>> + device_type = "memory";
>> + reg = <0x0 0x00c00000 0x0 0x80000000>;
>> + /* node 0 */
>> + numa-node-id = <0>;
>> + };
>> +
>> + memory@...00000000 {
>> + device_type = "memory";
>> + reg = <0x100 0x00000000 0x0 0x80000000>;
>> + /* node 1 */
>> + numa-node-id = <1>;
>> + };
>> +
>> + cpus {
>> + #address-cells = <2>;
>> + #size-cells = <0>;
>> +
>> + cpu@000 {
>
> Same here (leaving one of course).
>
>> + device_type = "cpu";
>> + compatible = "arm,armv8";
>> + reg = <0x0 0x000>;
>> + enable-method = "psci";
>> + /* node 0 */
>> + numa-node-id = <0>;
>> + };
>> + cpu@001 {
>
> and so on...
>
>> + device_type = "cpu";
>> + compatible = "arm,armv8";
>> + reg = <0x0 0x001>;
>
> Either all leading 0s or none.
>
>> + reg = <0x0 0x008>;
>> + enable-method = "psci";
>> + /* node 1 */
>
> Kind of a pointless comment.
>
> Wouldn't each cluster of cpus for a given numa node be in a different
> cpu affinity? Certainly not required by the architecture, but the common
> case at least.
>
>> + numa-node-id = <1>;
>> + };
>
> [...]
>
>> + pcie0: pcie0@...480,00000000 {
>
> Drop the 0x and the comma.
>
>> + compatible = "arm,armv8";
>> + device_type = "pci";
>> + bus-range = <0 255>;
>> + #size-cells = <2>;
>> + #address-cells = <3>;
>> + reg = <0x8480 0x00000000 0 0x10000000>; /* Configuration space */
>> + ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x70 0x00000000>;
>> + /* node 0 */
>> + numa-node-id = <0>;
>> + };
>> +
>> + pcie1: pcie1@...480,00000000 {
>
> ditto
>
>> + compatible = "arm,armv8";
>> + device_type = "pci";
>> + bus-range = <0 255>;
>> + #size-cells = <2>;
>> + #address-cells = <3>;
>> + reg = <0x9480 0x00000000 0 0x10000000>; /* Configuration space */
>> + ranges = <0x03000000 0x9010 0x00000000 0x9010 0x00000000 0x70 0x00000000>;
>> + /* node 1 */
>> + numa-node-id = <1>;
>> + };
>> +
>> + distance-map {
>> + compatible = "numa-distance-map-v1";
>> + distance-matrix = <0 0 10>,
>> + <0 1 20>,
>> + <1 1 10>;
>> + };
>> --
>> 1.8.1.4
thanks
Ganapat
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists