linux-kernel - Re: [PATCH-V2 1/1] HID: Force feedback support for the Logitech G920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db5d205435e01d8228b97a2d87ef42d.squirrel@mungewell.org>
Date:	Tue, 26 Jan 2016 12:03:57 -0700
From:	"Simon Wood" <simon@...gewell.org>
To:	"Edwin Velds" <e.velds@...il.com>
Cc:	linux-input@...r.kernel.org, "Simon Wood" <simon@...gewell.org>,
	"Jiri Kosina" <jkosina@...e.cz>,
	"Michal MalÃ½" 
	<madcatxster@...oid-pointer.net>,
	"elias vanderstuyft" <elias.vds@...il.com>,
	"Benjamin Tissoires" <benjamin.tissoires@...hat.com>,
	"Dmitry Torokhov" <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, "Edwin Velds" <e.velds@...il.com>
Subject: Re: [PATCH-V2 1/1] HID: Force feedback support for the Logitech
 G920

On Sun, January 10, 2016 4:25 pm, Edwin Velds wrote:
> This patch implements force feedback support for the Logitech
> G920 Driving Force Racing Wheel. It is a generic implementation
> of feature 0x8123 of the Logitech HID++ protocol and should be usable for
> any future devices that implement this feature.

Apologies for being slow on this (something to do with changing jobs and
accomodation ;-).

Doesn't patch cleanly on Linus' HEAD due to:
--
commit d8ce9bf5551bfea431893bdd0a943f24a5170828
Author: Geliang Tang <geliangtang@....com>
Date:   Sun Dec 27 17:25:20 2015 +0800

    HID: move to_hid_device() to hid.h
--

A couple of white space issues:
--
ERROR: trailing whitespace
#114: FILE: drivers/hid/hid-logitech-hidpp.c:867:
+static const u8 HIDPP_FF_CONDITION_CMDS[] = { $

ERROR: trailing whitespace
#121: FILE: drivers/hid/hid-logitech-hidpp.c:874:
+static const char *HIDPP_FF_CONDITION_NAMES[] = { $
--

Note: The wheel _DOES_NOT_ auto switch to Logitech/HID mode (it is stuck
in XBox since the xpad changes where not included). Michal has an
alternative approach documented here:
--
Create a file named "046d:c261" in "/etc/usb_modeswitch.d" with the
following content:

# Logitech G920 Racing Wheel
DefaultVendor=046d
DefaultProduct=c261
MessageEndpoint=01
ResponseEndpoint=01
TargetClass=0x03
MessageContent="0f00010142"

Then run "usb_modeswitch -c /etc/modeswitch.d/046d:c291" as root and
watch the magic happen:)
--

Apart from these few minor points, but seems to work OK - tested against
G920 with older firmware.

Tested-by: Simon Wood <simon@...gewell.org>