linux-kernel - Re: [PATCH] genirq: fix trigger flags check for shared irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1601262142450.3886@nanos>
Date:	Tue, 26 Jan 2016 21:45:32 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Brian Starkey <brian.starkey@....com>
cc:	linux-kernel@...r.kernel.org, marc.zyngier@....com
Subject: Re: [PATCH] genirq: fix trigger flags check for shared irqs

On Tue, 26 Jan 2016, Brian Starkey wrote:

> For shared interrupts, if one requester passes in any IRQF_TRIGGER_*
> flags whilst another doesn't, __setup_irq() can erroneously fail.
> 
> The no-flags case should be treated as "already configured", so change
> __setup_irq() to only check that the flags match if any have been
> provided.

What happens if that "already configured", i.e. the default setting, is
conflicting with the newly requested interrupt?

I rather prefer the failure than the resulting silent wreckage.
 
Thanks,

	tglx