linux-kernel - [RFC PATCH 08/21] mmc: sdhci-sirf: check sdhci_get_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1453871264-3640-1-git-send-email-shawn.lin@rock-chips.com>
Date:	Wed, 27 Jan 2016 13:07:44 +0800
From:	Shawn Lin <shawn.lin@...k-chips.com>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	bcm-kernel-feedback-list@...adcom.com,
	linux-rpi-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>,
	Barry Song <baohua@...nel.org>, Weijun Yang <york.yang@....com>
Subject: [RFC PATCH 08/21] mmc: sdhci-sirf: check sdhci_get_of_property return value

sdhci_get_of_property may failed while probing, so we check
the return value here.

Cc: Barry Song <baohua@...nel.org>
Cc: Weijun Yang <york.yang@....com>
Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
---

 drivers/mmc/host/sdhci-sirf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
index 34866f6..3f8499f 100644
--- a/drivers/mmc/host/sdhci-sirf.c
+++ b/drivers/mmc/host/sdhci-sirf.c
@@ -195,7 +195,9 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
 	priv = sdhci_pltfm_priv(pltfm_host);
 	priv->gpio_cd = gpio_cd;
 
-	sdhci_get_of_property(pdev);
+	ret = sdhci_get_of_property(pdev);
+	if (ret)
+		return ret;
 
 	ret = clk_prepare_enable(pltfm_host->clk);
 	if (ret)
-- 
2.3.7