lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160127233953.GB5183@verge.net.au>
Date:	Thu, 28 Jan 2016 08:39:53 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Julian Anastasov <ja@....bg>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Wensong Zhang <wensong@...ux-vs.org>,
	linux-arm-kernel@...ts.infradead.org,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Wed, 27 Jan 2016, Arnd Bergmann wrote:
> 
> > The proc_create() and remove_proc_entry() functions do not reference
> > their arguments when CONFIG_PROC_FS is disabled, so we get a couple
> > of warnings about unused variables in IPVS:
> > 
> > ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable]
> > 
> > This removes the local variables and instead looks them up separately
> > for each use, which obviously avoids the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning")
> 
> 	Looks like your previous patch for ip_vs_app_net_cleanup
> was delayed in ipvs-next tree. I guess, Simon should drop it and
> use this one instead when net-next opens:
> 
> Acked-by: Julian Anastasov <ja@....bg>

Thanks, and sorry about not pushing the other patch to net-next.
I have dropped it and queued up this one in its place.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ