linux-kernel - Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56A86C7D.6080708@ti.com>
Date:	Wed, 27 Jan 2016 09:06:37 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Dan Williams <dan.j.williams@...el.com>,
	<dri-devel@...ts.freedesktop.org>
CC:	Dave Hansen <dave@...1.net>, David Airlie <airlied@...ux.ie>,
	<linux-kernel@...r.kernel.org>,
	Julian Margetson <runaway@...dw.ms>, <linux-mm@...ck.org>,
	<akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed


On 26/01/16 20:37, Dan Williams wrote:
> pfn_t_to_page() honors the flags in the pfn_t value to determine if a
> pfn is backed by a page.  However, vm_insert_mixed() was originally
> written to use pfn_valid() to make this determination.  To restore the
> old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() case
> and fallback to trusting pfn_valid().
> 
> Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t")

Thanks, this fixes the crash with omapdrm.

Tested-by: Tomi Valkeinen <tomi.valkeinen@...com>

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)