linux-kernel - Re: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127073300.GJ3368@x1>
Date:	Wed, 27 Jan 2016 07:33:00 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
	spear-devel@...t.st.com, Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module

On Mon, 25 Jan 2016, Arnd Bergmann wrote:

> When the thermal subsystem is a loadable module, the u8500 driver
> fails to build:
> 
> drivers/thermal/built-in.o: In function `db8500_thermal_probe':
> db8500_thermal.c:(.text+0x96c): undefined reference to `thermal_zone_device_register'
> drivers/thermal/built-in.o: In function `db8500_thermal_work':
> db8500_thermal.c:(.text+0xab4): undefined reference to `thermal_zone_device_update'
> 
> This changes the symbol to a tristate, so Kconfig can track the
> dependency correctly.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/db8500-prcmu.c | 3 +++
>  drivers/thermal/Kconfig    | 4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)

As this touches a core Thermal file, I think it's better off going in
via that tree.  If that's a problem, I can take it with the relevant
Acks.

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index 2f4a1279b094..c0a86aeb1733 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2045,6 +2045,7 @@ int db8500_prcmu_config_hotmon(u8 low, u8 high)
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(db8500_prcmu_config_hotmon);
>  
>  static int config_hot_period(u16 val)
>  {
> @@ -2071,11 +2072,13 @@ int db8500_prcmu_start_temp_sense(u16 cycles32k)
>  
>  	return config_hot_period(cycles32k);
>  }
> +EXPORT_SYMBOL_GPL(db8500_prcmu_start_temp_sense);
>  
>  int db8500_prcmu_stop_temp_sense(void)
>  {
>  	return config_hot_period(0xFFFF);
>  }
> +EXPORT_SYMBOL_GPL(db8500_prcmu_stop_temp_sense);
>  
>  static int prcmu_a9wdog(u8 cmd, u8 d0, u8 d1, u8 d2, u8 d3)
>  {
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 0852fd028dc9..7c92c09be213 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -237,8 +237,8 @@ config DOVE_THERMAL
>  	  framework.
>  
>  config DB8500_THERMAL
> -	bool "DB8500 thermal management"
> -	depends on ARCH_U8500
> +	tristate "DB8500 thermal management"
> +	depends on MFD_DB8500_PRCMU
>  	default y
>  	help
>  	  Adds DB8500 thermal management implementation according to the thermal

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog