linux-kernel - Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127080926.GA31516@gondor.apana.org.au>
Date:	Wed, 27 Jan 2016 16:09:26 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Li, Weigang" <weigang.li@...el.com>
Cc:	Joonsoo Kim <js1304@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Minchan Kim <minchan@...nel.org>,
	Dan Streetman <ddstreet@...e.org>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression
 support

On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote:
> On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote:
> >
> > The acomp is also SG-based, while scomp only accepts flat buffer.
> 
> Right, but do we need a pointer-based scomp at all? IPComp would
> certainly be better off with an SG-based interface.  Any other
> users of compression are presumably dealing with large amounts
> of data where an SG interface would make more sense.
> 
> A pointer interface makes sense for shash because you may be hashing
> 16 bytes at a time.  Nobody sane is going to be compressing 16 bytes,
> or are they?

Note that I'm fine with keeping an scomp interface underneath
for those algorithms where the best way to handle SG input is
to linearise things.  But I would prefer that this interface is
not exposed to kernel users unless it is absolutely required.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt