linux-kernel - Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDACDTnmMdnefaWEK_Mt-5CSP1bndXERVseuJ3KLWbCHQ@mail.gmail.com>
Date:	Wed, 27 Jan 2016 11:13:17 +0200
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Matt Ranostay <mranostay@...il.com>
Cc:	Cristina Moraru <cristina.moraru09@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Ludovic Tancerel <ludovic.tancerel@...lehightech.com>,
	geert@...ux-m68k.org,
	Krzysztof Kozłowski <k.kozlowski@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"octavian.purdila@...el.com" <octavian.purdila@...el.com>,
	Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02

On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@...il.com> wrote:
> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
> <cristina.moraru09@...il.com> wrote:
>> This patch adds support for Hoperf th02 humidity and
>> temperature sensor as it uses same register definitions
>> as si7005
>>
>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>
>> Signed-off-by: Cristina Moraru <cristina.moraru09@...il.com>
>> ---
>>  drivers/iio/humidity/Kconfig  | 3 ++-
>>  drivers/iio/humidity/si7005.c | 1 +
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>> index c1f3a21..866dda1 100644
>> --- a/drivers/iio/humidity/Kconfig
>> +++ b/drivers/iio/humidity/Kconfig
>> @@ -43,7 +43,8 @@ config SI7005
>>           humidity and temperature sensor.
>>
>>           To compile this driver as a module, choose M here: the module
>> -         will be called si7005.
>> +         will be called si7005. This driver also
>> +         supports Hoperf TH02 Humidity and Temperature Sensor.
>
> This probably shouldn't be changing the Kconfig description. Since if
> every driver added a line for each device/variant it supported
> everything would get quite wordy.

Wordy is good :). We usually add all the supported chips in the Kconfig.
See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.

thanks,
Daniel.