linux-kernel - Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2016 11:49:28 +0200
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Lucas De Marchi <lucas.de.marchi@...il.com>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	lkml <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Lucas De Marchi <lucas.demarchi@...el.com>
Subject: Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

On Wed, Jan 27, 2016 at 12:28 AM, Lucas De Marchi
<lucas.de.marchi@...il.com> wrote:
> Hi,
>
> On Thu, Jan 14, 2016 at 2:25 PM, Daniel Baluta <daniel.baluta@...el.com> wrote:
>> The driver has sysfs readings with runtime PM support for power saving.
>> It also offers buffer support that can be used together with IIO software
>> triggers.
>>
>> Datasheet can be found here:
>>         http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf
>>
>> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
>> ---
>
> [ ... ]
>
>> +static const struct i2c_device_id ads1015_id[] = {
>> +       {"ads1015", 0},
>
> shouldn't this be ti-ads1015 so not to clash with the hwmon driver?

The plan is to remove hwmon driver and replace it with the a backward
compatbile IIO driver.

I am now working to address the comments from this thread and send a v2
asap.

>
>> +       {}
>> +};
>> +MODULE_DEVICE_TABLE(i2c, ads1015_id);
>> +
>> +static struct i2c_driver ads1015_driver = {
>> +       .driver = {
>> +               .name = ADS1015_DRV_NAME,
>
> same here, otherwise we will have an i2c:ads1015 alias

thanks,
Daniel.