linux-kernel - Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453891554.2351.1.camel@sipsolutions.net>
Date:	Wed, 27 Jan 2016 11:45:54 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Jonas Gorski <jogo@...nwrt.org>,
	Florian Fainelli <f.fainelli@...il.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Kevin Cernekee <cernekee@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	MIPS Mailing List <linux-mips@...ux-mips.org>,
	Simon Arlott <simon@...e.lp0.eu>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian
 behaviour for syscon

On Wed, 2016-01-27 at 11:33 +0100, Jonas Gorski wrote:
> 
> > +++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
> > @@ -54,7 +54,7 @@
> >                 periph_cntl: syscon@...00000 {
> >                         compatible = "syscon";
> >                         reg = <0x10000000 0x14>;
> > -                       little-endian;
> > +                       native-endian;
> 
> But native-endian == big-endian usually for bcm63xx, so is this
> actually a bugfix?
> 

It's complicated :)

These were originally specified as little-endian because it _worked_,
but that was only because of an issue with the code - it was getting
byteswapped twice.

This was "fixed" in commit 29bb45f25ff3051354ed330c0d0f10418a2b8c7c,
and I assume this DT file was created/copied before that commit and
didn't get that update due to merge delays. So after that commit, this
file couldn't have worked, but that's how it got to this point.

johannes