[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.11.1601271211100.3886@nanos>
Date: Wed, 27 Jan 2016 12:14:14 +0100 (CET)
From: Thomas Gleixner <tglx@...utronix.de>
To: John Stultz <john.stultz@...aro.org>
cc: lkml <linux-kernel@...r.kernel.org>,
Ruchi Kandoi <kandoiruchi@...gle.com>,
Arjan van de Ven <arjan@...ux.intel.com>,
Oren Laadan <orenl@...lrox.com>,
Micha Kalfon <micha@...lrox.com>,
Rom Lemarchand <romlem@...roid.com>,
Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [RFC][PATCH v2] prctl: Add PR_SET_TIMERSLACK_PID for setting
timer slack of an arbitrary thread.
On Mon, 25 Jan 2016, John Stultz wrote:
> From: Ruchi Kandoi <kandoiruchi@...gle.com>
>
> This allows power/performance management software to set timer
> slack for other threads according to its policy for the thread
> (such as when the thread is designated foreground vs. background
> activity)
>
> Second argument is similar to PR_SET_TIMERSLACK, if non-zero
> then the slack is set to that value otherwise sets it to the
> default for the thread.
>
> Takes PID of the thread as the third argument.
>
> This interface checks that the calling task has permissions to
> to use PTRACE_MODE_ATTACH on the target task, so that we can
> ensure arbitrary apps do not change the timer slack for other
> apps.
>
> Additional fixes from Ruchi and Micha Kalfon <micha@...lrox.com>
> have been folded into this patch to make it easier to reivew.
>
> Cc: Arjan van de Ven <arjan@...ux.intel.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Oren Laadan <orenl@...lrox.com>
> Cc: Micha Kalfon <micha@...lrox.com>
> Cc: Ruchi Kandoi <kandoiruchi@...gle.com>
> Cc: Rom Lemarchand <romlem@...roid.com>
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Signed-off-by: Ruchi Kandoi <kandoiruchi@...gle.com>
> [jstultz:
> * Folded in CAP_SYS_NICE check from Ruchi.
> * Folded in fix misplaced PR_SET_TIMERSLACK_PID case fix from
> Micha.
> * Folded in make PR_SET_TIMERSLACK_PID pid namespace aware fix
> from Micha.
> * Changed PR_SET_TIMERSLACK_PID so it didn't collide with
> already upstream prctrl values.
> * Reworked commit message.
> * Moved from CAP_SYS_NICE to PTRACE_MODE_ATTACH for permissions
> checks]
> Signed-off-by: John Stultz <john.stultz@...aro.org>
Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
Powered by blists - more mailing lists