linux-kernel - Re: [PATCH v1 1/1] lib/vsprintf: define special_hex_number_unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1453897153.2521.240.camel@linux.intel.com>
Date:	Wed, 27 Jan 2016 14:19:13 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] lib/vsprintf: define
 special_hex_number_unsigned_long()

On Tue, 2016-01-26 at 20:44 -0800, Andrew Morton wrote:
> On Thu, 14 Jan 2016 14:34:49 +0200 Andy Shevchenko <andriy.shevchenko
> @linux.intel.com> wrote:
> 
> > Define a macro for convenient use with values of unsigned long
> > type.
> > 
> > The value in symbol_string() is type of unsigned long. Use it
> > instead of void *
> > when getting sizeof() of it.
> > 
> > ...
> > 
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -529,6 +529,9 @@ char *special_hex_number(char *buf, char *end,
> > unsigned long long num, int size)
> >  	return number(buf, end, num, spec);
> >  }
> >  
> > +#define special_hex_number_unsigned_long(buf, end, n) \
> > +	special_hex_number(buf, end, (unsigned long)n,
> > sizeof(unsigned long))
> > +
> >  static void move_right(char *buf, char *end, unsigned len,
> > unsigned spaces)
> >  {
> >  	size_t size;
> > @@ -684,7 +687,7 @@ char *symbol_string(char *buf, char *end, void
> > *ptr,
> >  
> >  	return string(buf, end, sym, spec);
> >  #else
> > -	return special_hex_number(buf, end, value, sizeof(void
> > *));
> > +	return special_hex_number_unsigned_long(buf, end, value);
> >  #endif
> >  }
> >  
> > @@ -1446,7 +1449,7 @@ char *clock(char *buf, char *end, struct clk
> > *clk, struct printf_spec spec,
> >  #ifdef CONFIG_COMMON_CLK
> >  		return string(buf, end, __clk_get_name(clk),
> > spec);
> >  #else
> > -		return special_hex_number(buf, end, (unsigned
> > long)clk, sizeof(unsigned long));
> > +		return special_hex_number_unsigned_long(buf, end,
> > clk);
> >  #endif
> >  	}
> >  }
> 
> I'm not sure this is worth the effort.

Drop it then! I'm fine with any decision.


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy