linux-kernel - Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160127124700.GL6042@sirena.org.uk>
Date:	Wed, 27 Jan 2016 12:47:00 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Jianqun Xu <jay.xu@...k-chips.com>,
	Sonny Rao <sonnyrao@...omium.org>,
	Caesar Wang <wxt@...k-chips.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	leozwang@...gle.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Kees Cook <keescook@...gle.com>
Subject: Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing
 output clock to codec

On Tue, Jan 26, 2016 at 10:52:25AM +0100, Heiko Stübner wrote:
> Am Montag, 25. Januar 2016, 09:15:31 schrieb Jianqun Xu:
> > 在 23/01/2016 01:18, Mark Brown 写道:

> > > controller driver that ensures that the clock is enabled.  The driver
> > > that manages the clock should be the one that uses it, like I say this
> > > means you should add the code to enable the clock to the CODEC driver if
> > > the CODEC driver needs the clock enabled.

> > But the property responsible to the factor, not care if the mclk source
> > clock is enabled or not. So does the simple-card driver can add support
> > to enable/disable mclk ?

> The mclk-input is part of the codec I'd think. So you'd want the clocks-
> property in the i2c entry describing the codec itself and implement the clk 
> operations in the codec driver as well.

> See codec-drivers for da7213, da7218,max98090 and many more for reference.

Yes, as I have said repeatedly including in the mail quoted above the
CODEC is using the clock so should be managing it.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)