[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160127145756.GR6042@sirena.org.uk>
Date: Wed, 27 Jan 2016 14:57:56 +0000
From: Mark Brown <broonie@...nel.org>
To: Damien Horsley <Damien.Horsley@...tec.com>
Cc: alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
James Hartley <james.hartley@...tec.com>
Subject: Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio
card
On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote:
> + - clock-names : Includes the following entries:
> + "audio_pll" The audio PLL
> + "i2s_mclk" The i2s reference clock
> + Also connected to i2s_out_0_mclk output
> + "dac_mclk" Dac reference clock. Connected to i2s_dac_clk output
Why are these (especially the dac_mclk and i2s_mclk) properties of the
card and not of the drivers for the respective devices?
> + - img,mute-gpio : phandle of the mute gpio
> +
> + - img,hp-det-gpio : phandle of the headphone detect gpio
The DT maintainers would prefer those to be named -gpios.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists